@real-lazy-coder brilliant PR! 👌 Thanks for doing all the work. It is just missing some test coverage. Have you tried EarlyAI to generate test code? Or the Cursor AI Editor?

@bennycode I'm on the struggle bus. For the life of me I cannot figure out how to get 100% test coverage on the PSAR.

 ParabolicSAR.ts         |     100 |    97.67 |     100 |     100 | 108,152   

These are edge cases and I'm at a loss. Any guidance?

@real-lazy-coder brilliant PR! 👌 Thanks for doing all the work. It is just missing some test coverage. Have you tried EarlyAI to generate test code? Or the Cursor AI Editor?

I'm using Claude Code quite a bit these days. But it's 🔥 my 💰 at a blazing fast rate!

I'll look into EarlyAI. Thanks,

These are edge cases and I'm at a loss. Any guidance?

I ran the tests and reviewed the HTML output in the /coverage directory. It looks like we need to cover scenarios where it falls back to previousLow (line 108):

sar = previousLow.lt(sar) ? previousLow : sar;

Similarly, we should add a test case where it falls back to previousHigh (line 158):

sar = previousHigh.gt(sar) ? previousHigh : sar;

@real-lazy-coder I was able to write tests for the missing cases -> real-lazy-coder#1

Example:

it('adjusts the SAR when the previous low is lower than the pre-previous low', () => {
  const psar = new PSAR({accelerationMax: 0.2, accelerationStep: 0.02});
  const prePreviousLow = 8;
  const previousLow = 7;

  psar.add({high: 10, low: 9});
  psar.add({high: 11, low: prePreviousLow});
  psar.add({high: 12, low: previousLow});

  expect(psar.getResultOrThrow().toString()).toBe('12');
});

@real-lazy-coder shall we get this in? 😀

I have 1 last line I need to write a test for. I'm currently on vacation with my family. I will get this finalized when I return next week.

I have 1 last line I need to write a test for. I'm currently on vacation with my family. I will get this finalized when I return next week.

Sure! Take it easy and enjoy the vacation with your loves ones. 😊

Hey @real-lazy-coder, can I support you to get the PR done? Hope you had a nice vacation! 😀